Apply more ZEP 1 feedback #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbms
reviewed
Nov 21, 2022
jbms
reviewed
Nov 21, 2022
jbms
reviewed
Nov 21, 2022
jbms
reviewed
Nov 21, 2022
jstriebel
commented
Nov 22, 2022
jstriebel
commented
Nov 22, 2022
jstriebel
added
the
core-protocol-v3.0
jstriebel
requested review from
constantinpape,
joshmoore,
rabernat,
jakirkham and
jbms
rabernat
reviewed
Nov 25, 2022
rabernat
reviewed
Nov 25, 2022
Co-authored-by: Ryan Abernathey <ryan.abernathey@gmail.com>
|
@jbms @rabernat Is there anything else missing IYO? I'd love to merge this soon to avoid conflicts and to have the feedback incorporated into https://zarr-specs.readthedocs.io/en/latest/core/v3.0.html. |
rabernat
approved these changes
Dec 1, 2022
|
Thanks @rabernat 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR applies review feedback from the ZEP1 review in PR #149. Most changes are clarifications and wording corrections. The only further reaching changes are about
metadata_key_suffixandmetadata_encoding, explained below. The changes for those fields are not finalized yet, and should be discussed further in #174, separate from this PR, to unblock the other changes. Sorry about mixing those up. If the related changes do not seem acceptable for the moment, I'd rather fall back to removing them and solve this in a separate issue/PR.Non editorial changes:
metadata_key_suffixinto themetadata_encodingmetadata field, specifying only the encoding schema there, not the metadata content. Changedmetadata_encodingto be an extension point.